NMEASentence/__getattr__: Graceful fail #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
** Return None and handle the error without raising an error. Technically raising an error after catching another is bad as it still creates a stack trace (causing a hard failure) and it demolishes the original stack. Here the return None is handled and a message is logged in debug format. The other way to resolve this on a hard failure is to reraise the origin after logging just call raise to preserve the stack. ** Altered the test that utilized this code.
|
/retest python 3.7 |
|
@Knio not sure if these tests can be rerun, but it didn't look like it. The python3.7 job is failing for a reason that doesn't appear to be related to the software. Can we rerun this to confirm? |
|
I don't think this is a good idea to silently fail for fields that were never defined, and goes against the normal Python behavior of every other object. It also doesn't solve #94, since that's accessing defined fields and not taking this code path, and will still fail on parsing None. I think 94 should be solved manually in the Python3+ also properly supports raising an exception from within an exception handler, and linking it to the original exception and stack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** Return None and handle the error without raising an error. Technically
raising an error after catching another is bad as it still creates a stack
trace (causing a hard failure) and it demolishes the original stack. Here the
return None is handled and a message is logged in debug format. The other way
to resolve this on a hard failure is to reraise the origin after logging just call
raise to preserve the stack.
** Altered the test that utilized this code.
Fix for #94